Open
Conversation
Continuation U2F HID packets with a sequence number equal to a custom command code are mistakenly processed as a custom command which leads to corrupted ping response and unwanted custom command execution. The current bugfix corrects this issue, the firmware works well now with any size of ping commands.
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz
force-pushed
the
67-1kb_ping_crash
branch
from
0253687 to
2755be7
Compare
Author
|
I have added missing brace and removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following patch should fix #67 (crash on 1kB ping message). Changes:
PINGas a custom command (only on FINAL stage firmware).ping.Porting fix from Nitrokey/nitrokey-fido-u2f-firmware, where it was tested. Not tested on U2F-Zero hardware. For solution-related questions please ask @adamglozik directly.
Edit 20180709: added missing brace and removed
TOFIXcommit.Fixes #67
CC: @adamglozik @jans23